Uncomment elasticsearch condition #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaen
reviewed
Jan 16, 2025
diracx/values.yaml
Outdated
| @@ -51,7 +51,8 @@ podSecurityContext: | |||
| # fsGroup: 2000 | |||
|
|
|||
| securityContext: | |||
| {} | |||
| fsGroup: 2000 | |||
There was a problem hiding this comment.
That looks good ! I am just not sure whether this should be the default value or if empty should be the default. I will try to test it on openshift before merging it
There was a problem hiding this comment.
2000 comes from the user internal to the chart/images, so I thought it should be inside.
volodymyrss
commented
Jan 16, 2025
README.md
Outdated
| @@ -350,6 +350,7 @@ Note that this configuration is trivial and does not follow production recommand | |||
| | ingress.enabled | bool | `true` | | | |||
| | ingress.tlsSecretName | string | `"myingress-cert"` | | | |||
| | initCs.enabled | bool | `true` | | | |||
| | initCs.securityContext.fsGroup | int | `2000` | | | |||
There was a problem hiding this comment.
Should I add a comment in the values to have some doc here?
chaen
force-pushed
the
129-figure-out-security-context
branch
from
dde2715 to
e2b9908
Compare
chaen
changed the title
chaen
force-pushed
the
129-figure-out-security-context
branch
from
e2b9908 to
533b1e0
Compare
chaen
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #129
Also I needed to uncomment elasticsearch condition, since there is not storageclass setting for it and it prevents deployment. I can take it out.