-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change timestamp to episode for logging #1325
Conversation
Great @theSquaredError. Now you just need to update the changelog (docs/misc/changelog). Add a line after the line 47. You can also add your name to the list of contributors at the end of the changelog! |
I have updated changelog |
Great, now let's see if the CI passes. In the meantime, can you check if there is a similar issue in the SB3-Contrib repository or in the RL-Zoo3 repository? |
There is same issue in SB3-Contrib repository |
Thanks, could you also open a PR on sb3 contrib repo? |
Thanks for your (first) contribution @theSquaredError 🎉 |
Hi @qgallouedec , I have opened PR for sb3 contrib repo. Can you tell me some other issues which I can solve as the next thing and what to do to understand the library better? |
Thank you for wanting to help improve the library. I recommend that you check out
help wanted
|
Description
Motivation and Context
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line