Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added policy changes #438

Closed
wants to merge 1 commit into from
Closed

Added policy changes #438

wants to merge 1 commit into from

Conversation

jcarlosroldan
Copy link

Description

  • Listed all policies not supported anymore (layer-normalized)
  • Listed all policies not supported for the time being (LSTM)

Motivation and Context

See this comment on issue 106.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

- Listed all policies not supported anymore (layer-normalized)
- Listed all policies not supported for the time being (LSTM)
@araffin
Copy link
Member

araffin commented May 17, 2021

Hello,
thanks for the PR, please do not forget to update the changelog (c.f. contributing guide and PR checklist).

@araffin araffin added the PR template not filled Please fill the pull request template label May 20, 2021
@araffin araffin mentioned this pull request May 23, 2021
14 tasks
@araffin
Copy link
Member

araffin commented May 23, 2021

closing in favor of #450

@araffin araffin closed this May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR template not filled Please fill the pull request template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants