fix: Fix MSVC warnings #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howjmay
force-pushed
the
msvc-warnings
branch
6 times, most recently
from
34e876a
to
ad95d7f
Compare
jserv
requested changes
Oct 5, 2023
howjmay
force-pushed
the
msvc-warnings
branch
6 times, most recently
from
12f14fa
to
bd67477
Compare
jserv
reviewed
Nov 5, 2023
jserv
reviewed
Nov 5, 2023
howjmay
force-pushed
the
msvc-warnings
branch
from
bd67477
to
e0123d2
Compare
|
I think the rest warnings should be false positive. We already avoided those cases with if conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.