Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A32 support in CI #620

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

Cuda-Chen
Copy link
Collaborator

Add A32 support in CI.

For @jonathanhue, if possible, kindly leave some suggestions as I have little experience on A32 binary running on Armv8-A.

@Cuda-Chen Cuda-Chen requested review from howjmay, jserv and marktwtn and removed request for jserv and marktwtn November 22, 2023 06:29
Makefile Outdated Show resolved Hide resolved
README.md Outdated
@@ -126,6 +126,10 @@ or
```shell
$ make CROSS_COMPILE=arm-linux-gnueabihf- check # ARMv7-A
```
or
``` shell
$ make CROSS_COMPILE=arm-linux-gnueabihf- A32=1 check # ARMv8-A running in 32-bit mode, i.e., A32 instruction set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, A32 is always 1, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. A32 always sets to 1 if we want to run test program compiled under A32 instruction set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If toolchain is set to arm-linux-gnueabihf-, A32 should not appear since the former implies the latter.

Copy link
Collaborator Author

@Cuda-Chen Cuda-Chen Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of using A32 for indicating A32 instruction set build is that we can not only test our code on AArch32 but also check whether the NEON optimization on A32 will create any impacts or not.

Nevertheless, we may set the -mcpu flag (link to readme of tinymembenchmark) in other Makefile input parameters such as CFLAGS, and I consider I can start to implement from this.

@Cuda-Chen Cuda-Chen force-pushed the add-armv8a-32bit-ci branch 2 times, most recently from 16ad16a to 8bbd6d0 Compare November 22, 2023 09:08
README.md Outdated Show resolved Hide resolved
Add A32 support in CI.

Choose Cortex-A32 as test target because it only supports
AArch32. Moreover, Cortex-A32 has Armv8-A Cryptographic Extension,
which is an ideal target for testing Cryptographic Extension conversions.
@Cuda-Chen Cuda-Chen requested a review from jserv November 27, 2023 09:21
@jserv jserv merged commit 243e90f into DLTcollab:master Nov 27, 2023
16 checks passed
@jserv
Copy link
Member

jserv commented Nov 27, 2023

Thank @Cuda-Chen for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants