Improve Manifest Cleanup documentation #704 #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timo-Breumelhof
changed the title
david-poindexter
requested changes
Nov 16, 2023
There was a problem hiding this comment.
@Timo-Breumelhof I made some minor tweaks to hopefully make this even more clear. See if it makes sense to you, and if it does, feel free to just commit my suggestion. Thanks! 🎉
|
@Timo-Breumelhof upon closer review, we now know there is no globbing support for deletion of folders at all (files only). So, I propose we modify this PR to just include the new folder example within the manifest. You good with this @Timo-Breumelhof? |
david-poindexter
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made two changes:
Fixes Manifest Cleanup Compontent improvements #704