Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] #195 - 내 정보UI 로직 변경 #200

Merged
merged 13 commits into from
Jan 27, 2024
Merged

Conversation

jeongdung-eo
Copy link
Member

@jeongdung-eo jeongdung-eo commented Nov 19, 2023

🫧 작업한 내용

  • 내 정보 UI 로직 수정했습니다.
  • 여러 구조체로 분리되어있던 data model 부분을 수정했습니다.
  • 애널리스틱 변수네이밍과 동일하게 url 네이밍을 수정했습니다.
  • 각 section의 네이밍 수정했습니다.

🔫 PR Point

  • 생각보다 ,,, 수정해야할 부분들이 많았습니다 ... 추가적으로 수정해야할 부분 코리 달아주시면 반영하겠습니다 :)
  • web뷰 전환을 SFSafariViewController이용해서 했는데 WebKit로 변경하는게 좋을까요 ???

📸 스크린샷

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-11-19.at.17.50.58.mp4

📮 관련 이슈

Copy link
Member

@hyesuuou hyesuuou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~
웹뷰 변경은 저희가 웹뷰 자체를 커스텀할게 아니라서 저는 안해도될거같아요~

@jeongdung-eo jeongdung-eo merged commit a4e0d58 into develop Jan 27, 2024
1 check passed
@jeongdung-eo jeongdung-eo deleted the feat/#195 branch January 27, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] 내 정보UI 로직 변경
2 participants