[Refactor] #196 - 디테일 성취 UI 로직 변경 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesuuou
reviewed
Jan 23, 2024
| guard let missionDailtData = self.missionDailyData else { return completion(nil) } | ||
| completion(missionDailtData) | ||
| } catch let err { | ||
| print(err.localizedDescription, 500) |
hyesuuou
approved these changes
Jan 23, 2024
| HomeAPI.shared.getDailyMission(date: date) { response in | ||
| guard let response = response else { return } | ||
| guard let data = response.data else { return } | ||
| self.updateData(item: data) |
There was a problem hiding this comment.
escaping 클로저 내부 self라서 weak self 함 해줘야 할듯합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🫧 작업한 내용
🔫 PR Point
기존 뷰는 VC -> background 뷰 -> title label과 collectionview로 구현하였습니다.
리팩토링하면서 background 뷰를 구현하지 않고 collectionview를 이용해서 기존의 title label을 collectionview의 header뷰로 구현했습니다.
📸 스크린샷
📮 관련 이슈