[Feat] #206 - 알림 권한 요청 다이얼로그 구현 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongdung-eo
approved these changes
Nov 26, 2023
Comment on lines
253
to
259
| if let windowScene = UIApplication.shared.connectedScenes.first as? UIWindowScene, | ||
| let window = windowScene.windows.first { | ||
| let tabBarController = TabBarController() | ||
| let navigationController = UINavigationController(rootViewController: tabBarController) | ||
| navigationController.isNavigationBarHidden = true | ||
| window.rootViewController = navigationController | ||
| window.makeKeyAndVisible() |
There was a problem hiding this comment.
#193 액세스 토큰 로직처리하면서 SceneDelgate에 changeRootViewControllerTo 메서드를 만들어뒀어여! #193 머지 후에 아래와 같이 변경해도 좋을 것 같아욤 :)
Suggested change
| if let windowScene = UIApplication.shared.connectedScenes.first as? UIWindowScene, | |
| let window = windowScene.windows.first { | |
| let tabBarController = TabBarController() | |
| let navigationController = UINavigationController(rootViewController: tabBarController) | |
| navigationController.isNavigationBarHidden = true | |
| window.rootViewController = navigationController | |
| window.makeKeyAndVisible() | |
| SceneDelegate.shared?.changeRootViewControllerTo(TabBarController()) |
There was a problem hiding this comment.
헉 감사합니다!! #193 머지 후 수정하겠습니다 :)
| } | ||
|
|
||
| func requestNotification() { | ||
| // UNUserNotificationCenter.current().delegate = self |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🫧 작업한 내용
🔫 PR Point
🥲
📸 스크린샷
KakaoTalk_Video_2023-11-23-21-14-59.mp4
📮 관련 이슈