Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #221 - 다이얼로그뷰 앰플리튜드 이벤트 추가 #222

Merged
merged 2 commits into from
Jan 29, 2024
Merged

[Feat] #221 - 다이얼로그뷰 앰플리튜드 이벤트 추가 #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
008b016
[Feat] #221 - 다이얼로그뷰의 앰플리튜드 이벤트 추가
yungu0010 Jan 18, 2024
6ec198c
[Merger] develop into feature/#221
yungu0010 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions iOS-NOTTODO/iOS-NOTTODO.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,7 +1587,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 0;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = CQJ9UKUU35;
GENERATE_INFOPLIST_FILE = YES;
Expand Down Expand Up @@ -1625,7 +1625,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 0;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = CQJ9UKUU35;
GENERATE_INFOPLIST_FILE = YES;
Expand Down
4 changes: 3 additions & 1 deletion iOS-NOTTODO/iOS-NOTTODO/Global/Enum/AnalyticsEvent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ enum AnalyticsEvent {
case clickOnboardingNext3(select: [String])
case clickOnboardingNext4
case clickOnboardingNext5
case clickOnboardingNext6

var name: String {
switch self {
Expand All @@ -35,7 +36,7 @@ enum AnalyticsEvent {
case .clickOnboardingNext3: return "click_onboarding_next_3"
case .clickOnboardingNext4: return "click_onboarding_next_4"
case .clickOnboardingNext5: return "click_onboarding_next_5"
case .clickOnboardingNext6: return "click_onboarding_next_6"
}
}

Expand All @@ -46,6 +47,7 @@ enum AnalyticsEvent {
case .clickOnboardingNext3(select: let select): return ["onboard_select": select]
case .clickOnboardingNext4: return nil
case .clickOnboardingNext5: return nil
case .clickOnboardingNext6: return nil
}
}
}
Expand Down
1 change: 1 addition & 0 deletions ...DO/Presentation/NotificatoinDialog/ViewControllers/NotificationDialogViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,5 +183,6 @@ extension NotificationDialogViewController {
@objc
private func buttonTapped() {
buttonHandler?()
AmplitudeAnalyticsService.shared.send(event: AnalyticsEvent.OnboardingClick.clickOnboardingNext6)
}
}