[Fix] #223 - 다이얼로그 '허용' 선택 후 토글 오류 수정 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 설정 창으로 이동할 때가 아니라 알림 설정 변경 후 값에 따라 알맞은 이벤트 송신
hyesuuou
approved these changes
Jan 23, 2024
| @@ -45,13 +45,15 @@ public final class KeychainUtil { | |||
| static func getAppleEmail() -> String { | |||
| UserDefaults.standard.string(forKey: DefaultKeys.appleEmail) ?? "연동된 이메일 정보가 없습니다" | |||
| } | |||
|
|
|||
| static func getBool(_ key: String) -> Bool { | |||
There was a problem hiding this comment.
프로퍼티가 추가되면 계속 함수가 추가되는 구조라 제네릭을 이용한 Keychain 관련 Util을 만들어봐도 좋을것 같아요 ㅎ.ㅎ
나중에 시간나면 같이 만들어봐여,,
There was a problem hiding this comment.
오 좋습니다!! 이번 리팩 때 이 부분도 수정해보아요 , ,
jeongdung-eo
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🫧 작업한 내용
🔫 PR Point
getBool(_ key: String)를 만들어보았습니다. 이렇게 하면 가독성이 더 좋을 것 같아서요!또한 기존에
UserDefault.standard.bool로 접근하던 것을 모두 해당 함수로 변경했습니다. 공통 알림 모달 구현에도 같은 로직이 사용되는데 getBool로 바꾸시는거 어떠신가요?_?📸 스크린샷
📮 관련 이슈