[Fix] #226 - 공통 알림모달 로직 수정 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesuuou
approved these changes
Jan 27, 2024
| private var isSelected: Bool { | ||
| return KeychainUtil.isSelected() | ||
| } | ||
| private var isSelected: Bool = false |
There was a problem hiding this comment.
어떤게 선택된건지 변수명이 좀더 명확하면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🫧 작업한 내용
공통 알림 모달 로직 수정했습니다.
다음 공통 모달이 재등장 하는 시점을 앱을 껐다가 추후 다시 들어왔을 때로 수정
앰플리튜드 이벤트 추가했습니다.
🔫 PR Point
📸 스크린샷
default.mov
Simulator.Screen.Recording.-.iPhone.15.-.2024-01-24.at.19.16.50.mov
📮 관련 이슈