Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #231 - 공통 모달 컨텐츠 변경 #233

Merged
merged 4 commits into from
Feb 18, 2024
Merged

[Feat] #231 - 공통 모달 컨텐츠 변경 #233

merged 4 commits into from
Feb 18, 2024

Conversation

yungu0010
Copy link
Member

🫧 작업한 내용

  • 공통 모달 컨텐츠를 변경했습니다.
  • 라벨의 특정 문구만 highlight 해주는 함수를 추가했습니다. 아래와 같이 사용하시면 됩니다.
UILabel.partHighlightText(targetString: "일일 인증", targetHighlightColor: .green2 ?? .black)

🔫 PR Point

  • 그런데 매번 공통 알림 모달 컨텐츠가 바뀔 때마다 UI 요소를 변경하는 방법이 최선일까요..? 저도 다른 방법이 생각나지 않아 우선 UI 구현을 하긴 했는데 작업을 반복하지 않아도 되는 좋은 방법이 있다면 알려주세요. . .

📸 스크린샷

구현 내용 스크린샷
공통 알림 모달 컨텐츠 변경

📮 관련 이슈

@yungu0010 yungu0010 added this to the SP7 milestone Feb 16, 2024
@yungu0010 yungu0010 self-assigned this Feb 16, 2024
jeongdung-eo
jeongdung-eo approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@jeongdung-eo jeongdung-eo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 ><

@yungu0010 yungu0010 merged commit d007877 into develop Feb 18, 2024
1 check passed
@yungu0010 yungu0010 deleted the feature/#231 branch March 14, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongdung-eo jeongdung-eo jeongdung-eo approved these changes

Assignees

@yungu0010 yungu0010

Labels
Feat 윤서
Projects
None yet
Milestone
SP7
Development

Successfully merging this pull request may close these issues.

[Feat] 공통 모달 컨텐츠 변경
2 participants
@yungu0010 @jeongdung-eo