Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging about authentication #324

Merged

Conversation

jesse-ross
Copy link
Contributor

This improves the messages about the changes in authentication which are given when people try to run the old authenticate_sb().

  • The message displayed whenever that function is run now states that SB has switched over to requiring MFA, and mentions that role accounts are an exception can still use password-based login.
  • The spurious "Unable to authenticate to legacy SB." warning is now removed. I think we can rely on the message when the function is called, or on people seeing that is_logged_in() == FALSE

Closes #323.

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9f3ab9d) 39.62% compared to head (e06015c) 39.48%.

❗ Current head e06015c differs from pull request most recent head bbd31a7. Consider uploading reports for the commit bbd31a7 to get more accurate results

Files Patch % Lines
R/authenticate_sb.R 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   39.62%   39.48%   -0.14%     
==========================================
  Files          23       23              
  Lines         853      856       +3     
==========================================
  Hits          338      338              
- Misses        515      518       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblodgett-usgs dblodgett-usgs merged commit 47e85e4 into DOI-USGS:main Feb 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confusing warning when logging in with role accounts
3 participants