From 9e34281965e22d30e40aa57f1dbe5bcb12066ba4 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 17 Jul 2024 19:37:19 +0300 Subject: [PATCH] common/mlx5: remove unneeded field when modify RQ table The attribute "rqt_max_size" of the RQT(RQ table) context is only needed by when creating a new one. When modifying an old one, there is no need to set this attribute. The firmware usually ignored this unneeded field. When enabling some extra check, an error will be returned to prevent the code from continuing to run. In the meanwhile, this field will always be set to the maximal one fetched from the capability without any change. Removing the value set and leave it to 0 will help to solve the potential failure. Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 8e12ac50deb..9710dcedd39 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -1914,7 +1914,6 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, MLX5_SET64(modify_rqt_in, in, modify_bitmask, 0x1); rqt_ctx = MLX5_ADDR_OF(modify_rqt_in, in, rqt_context); MLX5_SET(rqtc, rqt_ctx, list_q_type, rqt_attr->rq_type); - MLX5_SET(rqtc, rqt_ctx, rqt_max_size, rqt_attr->rqt_max_size); MLX5_SET(rqtc, rqt_ctx, rqt_actual_size, rqt_attr->rqt_actual_size); for (i = 0; i < rqt_attr->rqt_actual_size; i++) MLX5_SET(rqtc, rqt_ctx, rq_num[i], rqt_attr->rq_list[i]);