From ab49fdbea754a576b522161a7f0a2dfb94e91cec Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 18 Jul 2024 12:35:16 -0700 Subject: [PATCH] net/netvsc: use ethdev API to set VF MTU The current code uses unnecessary locking to set VF MTU, resulting in deadlock on hot add/remove path. Fix this by using rte_eth_dev_set_mtu() to set VF MTU. Fixes: 45c83603087e ("net/netvsc: support MTU set") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Signed-off-by: Long Li Reviewed-by: Wei Hu --- drivers/net/netvsc/hn_vf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c index 6b3d0eb0c83..b664beaa5dd 100644 --- a/drivers/net/netvsc/hn_vf.c +++ b/drivers/net/netvsc/hn_vf.c @@ -264,7 +264,7 @@ int hn_vf_add(struct rte_eth_dev *dev, struct hn_data *hv) goto exit; } - ret = hn_vf_mtu_set(dev, dev->data->mtu); + ret = rte_eth_dev_set_mtu(port, dev->data->mtu); if (ret) { PMD_DRV_LOG(ERR, "Failed to set VF MTU"); goto exit; @@ -796,7 +796,7 @@ int hn_vf_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) rte_rwlock_read_lock(&hv->vf_lock); vf_dev = hn_get_vf_dev(hv); if (hv->vf_ctx.vf_vsc_switched && vf_dev) - ret = vf_dev->dev_ops->mtu_set(vf_dev, mtu); + ret = rte_eth_dev_set_mtu(vf_dev->data->port_id, mtu); rte_rwlock_read_unlock(&hv->vf_lock); return ret;