fix: change order of JSON Schema to search mapper transformations #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the JSON Schema to search mapper, the suppression flags need to be addressed first, otherwise the jsonref.replace_refs function may remove them. Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
Updating pydantic from 2.8.2 to 2.9.2 triggers a change in JSON Schema from models: the lists with only 1 element get flatten. Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
ceberam
requested review from
vagenas,
cau-git,
PeterStaar-IBM and
dolfim-ibm
dolfim-ibm
previously approved these changes
Sep 25, 2024
This PR should be merged first, since the current version of pydantic ( |
| @@ -51,7 +51,7 @@ def test_json_schema_to_search_mapper_0(): | |||
| index_ref = _load(filename) | |||
|
|
|||
| diff = jsondiff.diff(index_ref, index_def) | |||
| print(json.dumps(index_def, indent=2)) | |||
| # print(json.dumps(index_def, indent=2)) | |||
| print(diff) | |||
There was a problem hiding this comment.
can we comment out the diff
| @@ -51,7 +51,7 @@ def test_json_schema_to_search_mapper_0(): | |||
| index_ref = _load(filename) | |||
|
|
|||
| diff = jsondiff.diff(index_ref, index_def) | |||
| print(json.dumps(index_def, indent=2)) | |||
| # print(json.dumps(index_def, indent=2)) | |||
| print(diff) | |||
| assert index_def == index_ref | |||
There was a problem hiding this comment.
Can you add a proper error message in case this assert fails
assert index_def == index_ref, "assert index_def != index_ref"
There was a problem hiding this comment.
In case of assertion failure, pytest should already provide enough context information but nevertheless I added a commit with more verbose, including the difference.
Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
ceberam
force-pushed
the
fix/json-schema-mapper
branch
from
5cf6f1f
to
3ee6c90
Compare
cau-git
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonref.replace_refsfunction may remove them.2.8.2to2.9.2triggers a change in JSON Schema from models: the lists with only 1 element get flattened. The documentation is automatically updated.