You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are many transition functions in our v5 codebase which have to take an argument data_t (an alias for nlohmann::json) in order to compile. However, this argument isn't used since the transitions are configured via an OKS object kept as member data in the DAQ module class. For v5 we should overload - or replace? - DAQModule::register_command - so that it takes argument-free transition functions.
The text was updated successfully, but these errors were encountered:
Closing this Issue since:
(1) there will still be commands which will need to take in info via a data_t argument, and
(2) it's not just a matter of overloading register_command thanks to CommandMap_t
There are many transition functions in our v5 codebase which have to take an argument
data_t
(an alias fornlohmann::json
) in order to compile. However, this argument isn't used since the transitions are configured via an OKS object kept as member data in the DAQ module class. For v5 we should overload - or replace? -DAQModule::register_command
- so that it takes argument-free transition functions.The text was updated successfully, but these errors were encountered: