Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQModule::register_command should support argument-free transitions in v5 #284

Closed
jcfreeman2 opened this issue Jul 3, 2024 · 1 comment

Comments

@jcfreeman2
Copy link
Contributor

There are many transition functions in our v5 codebase which have to take an argument data_t (an alias for nlohmann::json) in order to compile. However, this argument isn't used since the transitions are configured via an OKS object kept as member data in the DAQ module class. For v5 we should overload - or replace? - DAQModule::register_command - so that it takes argument-free transition functions.

@jcfreeman2
Copy link
Contributor Author

Closing this Issue since:
(1) there will still be commands which will need to take in info via a data_t argument, and
(2) it's not just a matter of overloading register_command thanks to CommandMap_t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant