Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pawel plesniak/terminate kill fixes #289

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Pawel plesniak/terminate kill fixes #289

merged 3 commits into from
Oct 29, 2024

Conversation

PawelPlesniak
Copy link
Contributor

Fixes Issue#185
Removes the use of a ProcessQuery object from terminate

plasorak
plasorak approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for v5.3.0 before merging this.

src/drunc/process_manager/utils.py Outdated Show resolved Hide resolved
@PawelPlesniak PawelPlesniak mentioned this pull request Oct 28, 2024
Open
@PawelPlesniak PawelPlesniak changed the base branch from develop to develop_post_v5.2.0 October 29, 2024 09:03
@PawelPlesniak PawelPlesniak merged commit cef0284 into develop_post_v5.2.0 Oct 29, 2024
@PawelPlesniak PawelPlesniak deleted the PawelPlesniak/TerminateKillFixes branch October 29, 2024 09:11
@PawelPlesniak PawelPlesniak mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasorak plasorak plasorak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PawelPlesniak @plasorak