Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding information to ps tables #312

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Conversation

PawelPlesniak
Copy link
Contributor

@PawelPlesniak PawelPlesniak commented Nov 14, 2024

Requires DUNE-DAQ/druncschema#33
Summary

  • Defined a command get_detector_name in controller/utils.py
  • Changed the format of the commands printed at the end of status to be CLI aligned (i.e. with - not _)
  • Changed the return types of commands in controller/controller_driver.py
  • Defined a describe method for children nodes. Not necessary for this PR but as we're going to move from REST to gRPC for all communications figured it would be good to have it there.
  • Split off propagate_fsm_command in rest_api_child and defined describe in ChildNode that parses the configuration and environment to fill Description. This may need chaning depending on whether we want there to be interaction with the daq_application itself to populate Description.
  • Added the configuration into the base descriptor for ChildNode

Copy link
Collaborator

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pawel, this looks good. I have a couple of comments, but otherwise this looks good. The one with about zip seem to be the most critical, as it sometimes leads to incorrectly assigning the info to the wrong app.

src/drunc/controller/controller.py Outdated Show resolved Hide resolved
src/drunc/controller/interface/shell_utils.py Show resolved Hide resolved
src/drunc/controller/interface/shell_utils.py Outdated Show resolved Hide resolved
src/drunc/controller/interface/shell_utils.py Outdated Show resolved Hide resolved
@plasorak plasorak merged commit 5c9e8b4 into develop Nov 15, 2024
1 check failed
@plasorak plasorak deleted the PawelPlesniak/DetectorIDForStatus branch November 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants