Missing exception type in connectivity_service client publish function. #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the occasional slow startup of DAQ applications and
drunc
controller applications on Fermilab development computerdaq.fnal.gov
, I noticed that a particular exception type was not being caught in thepublish
function of thedrunc
ConnSvc client code. This PR has a code change that adds that exception type.The following steps can be used to demonstrate the behavior of this code change:
In the results of the first running of the
minimal_system_quick_test
in these sample instructions, one often seesReadTimeoutErrors
in the console output from the test, and one never sees publish attempt numbers great than one.In the results of the second running of the
minimal_system_quick_test
(i.e. with the changes from this PR), one does not seeReadTimeoutErrors
in the test output, and one does see publish attempt numbers greater than one.I believe that this demonstrates the value of this code change.