Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I noticed that when the ping failed, the controller went into error #332

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

eflumerf
Copy link
Member

status and the integration test I was running failed. Tracking down the issue was non-trivial, and would have been a lot easier if this message was not a debug, but an error.

status and the integration test I was running failed. Tracking down the
issue was non-trivial, and would have been a lot easier if this message
was not a debug, but an error.
@plasorak plasorak self-requested a review December 18, 2024 21:28
Copy link
Collaborator

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for taking the time to find this problem.

@plasorak plasorak merged commit bbf1068 into develop Dec 18, 2024
2 checks passed
@plasorak plasorak deleted the eflumerf/RaisePingFailureLogLevel branch December 18, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants