Ron/issue 26 tlog issue bug #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bieryAtFnal
added
the
miscellaneous deliverable
bieryAtFnal
changed the base branch from
production/v4
to
prep-release/fddaq-v4.4.0
eflumerf
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appending of a TraceStreamer& operator<< method seem to be incorrect.
When, for example, in listrev,
TLOG() << listrev::ProgressUpdate(ERS_HERE, get_name(), oss_prog); is called,
the result is a message is like an ers::log and ers::error messages concatenated:
2024-Apr-03 10:38:53,912 LOG [void dunedaq::listrev::RandomDataListGenerator::do_work(std::atomic&) at /home/ron/work/DUNEPrj/fddaq-v4.3.0-a9-1-ron/sourcecode/listrev/plugins/RandomDataListGenerator.cpp:166] 2024-Apr-03 10:38:53,912 ERROR [void dunedaq::listrev::RandomDataListGenerator::do_work(std::atomic&) at /home/ron/work/DUNEPrj/fddaq-v4.3.0-a9-1-ron/sourcecode/listrev/plugins/RandomDataListGenerator.cpp:166] Generated list #1 with contents {384, 887, 778, 916} and size 4. DAQModule: rdlg
With the soon to be PR, the message becomes, as it should be:
2024-Apr-03 10:51:24,421 LOG [void dunedaq::listrev::RandomDataListGenerator::do_work(std::atomic&) at /home/ron/work/DUNEPrj/fddaq-v4.3.0-a9-1-ron/sourcecode/listrev/plugins/RandomDataListGenerator.cpp:166] Generated list #1 with contents {384, 887, 778, 916} and size 4. DAQModule: rdlg