Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the database connections work, introduced pool recycling and sorted out the timezone issues by using utc #92

Closed
wants to merge 18 commits into from

Conversation

TiagoTAlves
Copy link
Collaborator

Changed run_number flag to run_num to make it fit with automatic insertRun (when running) and added a foreignkey to RunNumberMeta to fit with oracle database

To test please start a run using --dotnanorc ~np04daq/.nanorc-dev-usvc.json

…rtRun (when running) and added a foreignkey to RunNumberMeta to fit with oracle database
… more error checking for database connection errors
@TiagoTAlves TiagoTAlves requested a review from plasorak April 9, 2024 10:56
Copy link
Collaborator

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TiagoTAlves TiagoTAlves force-pushed the titavare/quick-fix branch 4 times, most recently from 6c197d0 to 917d56c Compare April 10, 2024 22:22
@TiagoTAlves TiagoTAlves changed the title Fixed the issue that wasn't tested properly Made the database connections work, introduced pool recycling and sorted out the timezone issues by using utc Apr 11, 2024
@TiagoTAlves
Copy link
Collaborator Author

Covered in #93

@TiagoTAlves TiagoTAlves deleted the titavare/quick-fix branch April 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants