-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the database connections work, introduced pool recycling and sorted out the timezone issues by using utc #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtRun (when running) and added a foreignkey to RunNumberMeta to fit with oracle database
… more error checking for database connection errors
plasorak
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TiagoTAlves
force-pushed
the
titavare/quick-fix
branch
4 times, most recently
from
April 10, 2024 22:22
6c197d0
to
917d56c
Compare
TiagoTAlves
changed the title
Fixed the issue that wasn't tested properly
Made the database connections work, introduced pool recycling and sorted out the timezone issues by using utc
Apr 11, 2024
Covered in #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed run_number flag to run_num to make it fit with automatic insertRun (when running) and added a foreignkey to RunNumberMeta to fit with oracle database
To test please start a run using
--dotnanorc ~np04daq/.nanorc-dev-usvc.json