Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch for SIGQUIT #251

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Catch for SIGQUIT #251

merged 1 commit into from
Mar 19, 2024

Conversation

sbutchart
Copy link

Fixes a problem where unintentional SIGQUIT was causing a core dump upon trying to detach from tmux session.

@plasorak
Copy link
Contributor

plasorak commented Mar 8, 2024

To test this: start nanorc and issue a SIGQUIT with ctrl-\ (or doing that twice if you are using tmux with the bind key set to ctrl-\, as is the case of np04daq nanorc on np04-srv-024)

@bieryAtFnal bieryAtFnal added the miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable label Mar 9, 2024
@sbutchart sbutchart mentioned this pull request Mar 11, 2024
Closed
@TiagoTAlves TiagoTAlves self-requested a review March 19, 2024 13:06
TiagoTAlves
TiagoTAlves approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@TiagoTAlves TiagoTAlves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested in np04_hddev tmux session

@TiagoTAlves TiagoTAlves merged commit 8f148a1 into production/v4 Mar 19, 2024
1 check passed
@TiagoTAlves TiagoTAlves deleted the sbutchar/fix-coredump branch March 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiagoTAlves TiagoTAlves TiagoTAlves approved these changes

Assignees
No one assigned
Labels
miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbutchart @plasorak @TiagoTAlves @bieryAtFnal