Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlgorithmPlugins Unit Test Raises Expected Error #275

Closed
aeoranday opened this issue Feb 22, 2024 · 0 comments · Fixed by #276
Closed

AlgorithmPlugins Unit Test Raises Expected Error #275

aeoranday opened this issue Feb 22, 2024 · 0 comments · Fixed by #276
Labels
bug Something isn't working maintenance Addresses user request or change in another part of the system

Comments

@aeoranday
Copy link
Member

The change in 16345ef to add errors for requesting a factory item that is not available was not propagated to the associated unit test. The test included a check that a nullptr is returned on such requests, so this now raises an error instead and fails the test.

std::unique_ptr<triggeralgs::TriggerActivityMaker> fake_maker = trigger::make_ta_maker("TriggerActivityMakerFakerPlugin");

@aeoranday aeoranday added bug Something isn't working maintenance Addresses user request or change in another part of the system labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Addresses user request or change in another part of the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant