Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some obsolete or missing configuration parameters #296

Closed
MRiganSUSX opened this issue Apr 10, 2024 · 1 comment
Closed

Some obsolete or missing configuration parameters #296

MRiganSUSX opened this issue Apr 10, 2024 · 1 comment

Comments

@MRiganSUSX
Copy link
Contributor

I've recently done a cleanup of the configurations, and there are some parameters/whole schemas that are unused and there are also some parameters that could/should be configurable but are instead hardcoded. Overview here:
config.cleanup.ods

unused schemas   weird params in used schemas  
tasetsink.jsonnet Unused ? tpchannelfilter: keep_collection hardcoded true in trigger_gen
faketpcreatorheartbeatmaker.jsonnet Unused ? tpchannelfilter: keep_induction hardcoded true in trigger_gen
tpsetbuffercreator.jsonnet (used in replay?) Replay ? tpchannelfilter: max_time_over_threshold Hardcoded 10000 in trigger_gen
    triggeractivitymaker: window_time Hardcoded 10000 in trigger_gen
    triggeractivitymaker: buffer_time calculated but multiplied by constant
    triggerzipper.jsonnet: max_latency_ms Hardcoded 1000 in trigger_gen
    triggerzipper.jsonnet: tolerate_incompleteness not set in trigger_gen, used in triggerzipper
    triggerzipper.jsonnet: completeness_tolerance not set in trigger_gen, used in triggerzipper
    txbuffer.jsonnet many hardcoded values
@ArturSztuc
Copy link
Contributor

In v5, trigger schema was cleaned up. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants