Possible readout window change in MLT when use_roi_readout is true #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indow on trigger time plus/minus the configured time window
bieryAtFnal
changed the title
|
This is a bug and the fix above is the intended behaviour. |
MRiganSUSX
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ModuleLevelTrigger::roi_readout_make_requests(), this change bases the readout window on trigger time plus/minus the configured time window...
Not sure if this change is reasonable, but without it, we get no data fragments from the DataLinkHandlers in the Readout Apps or TPBuffers in the Trigger App. To be discussed at the next Release Coordination meeting...