Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixing RTCM for v5.2 #356

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

ArturSztuc
Copy link
Contributor

Bugfixing RandomTCMaker after v5.2 performance tests.

Bug: when running with trigger rate of 0.01Hz or lower, RTCM would spit out TCs at much higher rate.
Fix: The issue was with using int for time intervals rather than uint64_ts. Changed from int to uint64_t
Test: Ran test configuration with low trigger rate (0.01Hz) on code before and after the fix for 300s, comparing raw file before and after. Changed from 1000s of triggers to 3, as expected.

Copy link
Contributor

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I used the change_rate command to set the trigger rate to 0.005 (one per 200 seconds). In a 620-second run, I observed four triggers, which is in the range of what we would expect (one at 0, 200, 400, and 600 seconds into the run).

Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed using change_rate_test

@ArturSztuc ArturSztuc merged commit fff7479 into prep-release/fddaq-v5.2.0 Nov 6, 2024
1 check passed
@ArturSztuc ArturSztuc deleted the asztuc/rtcm_bugfix branch November 6, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants