Add a test of the change-rate command to RandomTriggerCandidateMaker #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturSztuc
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Overall looks good to me, although the unit test doesn't pass for me.
I either keep getting:
🚨 Event count 4 is outside the tolerance of 1 from an expected value of 2 🚨
or
> assert len(run_nanorc.data_files) == expected_number_of_data_files
E AssertionError: assert 3 == 4
Which probably means more checks with RTCM are needed to confirm it definitely works... I don't understand how we get 4 events (maybe there's another bug hiding in RTCM somewhere?) or 3 data files where there's clearly 4 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.