18 implement detailed geometry for sand ecal endcaps #40
Conversation
…e of tabs and spaces in indentation
…or-sand-ecal-endcaps' into 23-add-builder-for-sand-ecal-endcap-single-module
…he SANDECALBARRELMOD and SANDECALENDCAP context
inherited from mother volume for several parameters
…-passive-slabs-in-curved-element-of-ecal-endcap-modules 29 fix positioning of the active and passive slabs in curved element of ecal endcap modules
…nto 30-fix-potitioning-of-the-active-and-passive-slabs-in-horizontal-element-of-ecal-endcap-modules
…-passive-slabs-in-horizontal-element-of-ecal-endcap-modules Fixed horizontal section IDs and positioning
…umes. Size of yoke endcaps are decreased a bit
…ed-geometry-for-sand-ecal-endcaps
There was a problem hiding this comment.
There are many places where indentation is using tabs rather than spaces. Could you replace those tabs with the right number of spaces? Only at places where you modified the code, but there please change the whole indented blocks.
Also, please add a summary of the changes/additions to the CHANGELOG.md file. Please make sure to add them to the right sub-section in the "Unreleased" section.
Also, does this change the default sand configuration (the one you can inspect here: https://dune.github.io/dunendggd/ )? Do you want a new geometry release after this merge?
| @@ -15,38 +15,60 @@ def configure(self, | |||
| PasSlabThickness=None, | |||
| ActiveSlabThickness=None, | |||
| nSlabs=None, | |||
| BackPlateThick=None, | |||
There was a problem hiding this comment.
The indentation does not align.
duneggd/SubDetector/SandECal.py
Outdated
| # self.EndcapDRmax=Q("1.73m") | ||
| # self.EndcapDRmin=Q("0.51m") |
There was a problem hiding this comment.
Pleas do not include any commented out lines without explanation what they are for or why they are commented out. When in doubt, just remove them.
|
Thank you @ast0815 for devoting time to this review. You requests have been addressed |
|
No problem :) I think the CHANGELOG entry is still missing though. |
|
Right, sorry |
|
ast0815
deleted the
18-implement-detailed-geometry-for-sand-ecal-endcaps
branch
No description provided.