FOB & SITREP missing for players on dedicated servers #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2020 18:28
On a dedicated server, SITREP and Requesting a FOB never appears. This looks to be because BIS_fnc_addCommMenuItem is local, so needs to be called on the client, and i cannot for the life of me see if it already is. So i've just added it to the bottom of fn_clientInit.sqf.
|
Anyone able to merge this PR? I've not got write to the repo. |
fritogotlayed
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Hey. Sorry about the lack of traction. I'm not really a maintainer here anymore. I'm not sure if the other maintainer is still active. Would you be interested in taking a maintenance role on the project? I can see about getting you the appropriate privileges if you would like.
|
Hi there, it's ok, life happens. And it's been a long time since I've looked at anything SQF but I could quite happily pick it up again. I'm happy once I've got perms to sweep through the open issues and close some stuff off and get some clarity on what to work on in the github issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On dedis the SITREP and Request FOB radio functions are missing. Looks to be because BIS_fnc_addCommMenuItem is per client and not run (as far as I can see). Adding the BIS_fnc_addCommMenuItem's to the bottom of fn_clientInit.sqf works well enough for both initial and JIP players.
Tested on SP, MP and Dedicated server. No issues found as a result of this.
Fixes #175, #135 and an unreported issue with SITREP not being available. (plus a typo and missing semicolon)
This change is