Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#167] 커뮤니티 작성 페이지 api #168

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[#167] 커뮤니티 작성 페이지 api #168

wants to merge 4 commits into from

Conversation

chan0310
Copy link
Contributor

@chan0310 chan0310 commented Jan 9, 2024

Issue

Description

스크린샷 2024-01-09 오후 9 15 52

Check List

  • PR 제목을 커밋 규칙에 맞게 작성
  • PR에 해당되는 Issue를 연결 완료
  • 적절한 라벨 설정
  • 작업한 사람 모두를 Assign
  • 작업한 팀에게 Code Review 요청 (Reviewer 등록)
  • main 브랜치의 최신 상태를 반영하고 있는지 확인

Screenshot

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daitssu-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:06am

@chan0310 chan0310 changed the title 커뮤니티 작성 [#167] 커뮤니티 작성 페이지 api Jan 9, 2024
@SujinKim1127
Copy link
Member

yarn build 하셔서 배포 안되는부분 확인해주세요!!

@SujinKim1127 SujinKim1127 added the feat 🔧 새로운 기능 관련된 Issue label Jan 14, 2024
@SujinKim1127 SujinKim1127 linked an issue Jan 14, 2024 that may be closed by this pull request
Copy link
Member

@SujinKim1127 SujinKim1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하시고 코멘트 남겨주세요!!

hidden
/>
</div>
<TitleBox fontSize={16}/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 이부분은 공통 스타일에 없는 부분인가요?

Comment on lines +16 to +22
{previewImage.length === 0 ? null : (
<>
{previewImage.map((image, index) => (
<ImageBox key={index} index={index} image={image}/>
))}
</>
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분은 && 연산자를 사용해서 작성해도 좋을것 같아요!

Comment on lines 7 to +9
options: string[]; // options를 문자열 배열로 변경
chosen?: string | null; // chosen을 문자열 또는 null로 변경
onChange?: (event: React.ChangeEvent<HTMLSelectElement>) => void; // onChange 타입 변경
onChange?: (e: ChangeEvent<HTMLSelectElement>) => void; // onChange 타입 변경
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 내용이 반영되었다면 주석을 같이 지워주시면 좋을것 같습니다!

Comment on lines 6 to +8
options: string[]; // options를 문자열 배열로 변경
chosen?: string | null; // chosen을 문자열 또는 null로 변경
onChange?: (event: React.ChangeEvent<HTMLSelectElement>) => void; // onChange 타입 변경
onChange?: (e: ChangeEvent<HTMLSelectElement>) => void; // onChange 타입 변경
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 주석도 지워주시면 좋을 것 같아요!

Comment on lines +76 to +85
const handleSubmit = async () => {
console.log("request start");

const response = await postCommunityWritingAPI({
topic: formData.selectedValue,
title: formData.title,
content: formData.content,
images: formData.previewImage,
});
console.log(response);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

콘솔도 같이 지워주세욥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 🔧 새로운 기능 관련된 Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2-2 찬우
2 participants