Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] : shadowing on plugin property #430

Merged
merged 2 commits into from
Apr 6, 2024
Merged

[FIX] : shadowing on plugin property #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cdb29a
fix: shadowing on plugin property from CortexPE\Commando\BaseCommand …
nicholass003 Apr 4, 2024
3e904b8
chore: update Commando virion
nicholass003 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Download Virion Dependencies
run: |
wget -O vendor/FormsUI.phar https://poggit.pmmp.io/r/209836/FormsUI_dev-20.phar
wget -O vendor/Commando.phar https://poggit.pmmp.io/r/216831/Commando_dev-34.phar
wget -O vendor/Commando.phar https://poggit.pmmp.io/r/233076/Commando_dev-41.phar
wget -O vendor/libPiggyUpdateChecker.phar https://poggit.pmmp.io/r/211732/libPiggyUpdateChecker_dev-2.phar
wget -O vendor/Customies.phar https://poggit.pmmp.io/r/216154/Customies.phar
- name: Run PHPStan
Expand Down
3 changes: 2 additions & 1 deletion src/DaPigGuy/PiggyCustomEnchants/commands/CustomEnchantsCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@
use DaPigGuy\PiggyCustomEnchants\PiggyCustomEnchants;
use pocketmine\command\CommandSender;
use pocketmine\player\Player;
use pocketmine\plugin\Plugin;
use pocketmine\utils\TextFormat;
use Vecnavium\FormsUI\SimpleForm;

class CustomEnchantsCommand extends BaseCommand
{
/** @var PiggyCustomEnchants */
protected $plugin;
protected Plugin $plugin;

public function onRun(CommandSender $sender, string $aliasUsed, array $args): void
{
Expand Down
3 changes: 2 additions & 1 deletion src/DaPigGuy/PiggyCustomEnchants/commands/subcommands/AboutSubCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@
use DaPigGuy\PiggyCustomEnchants\PiggyCustomEnchants;
use pocketmine\command\CommandSender;
use pocketmine\player\Player;
use pocketmine\plugin\Plugin;
use pocketmine\utils\TextFormat;
use Vecnavium\FormsUI\SimpleForm;

class AboutSubCommand extends BaseSubCommand
{
/** @var PiggyCustomEnchants */
protected $plugin;
protected Plugin $plugin;

public function onRun(CommandSender $sender, string $aliasUsed, array $args): void
{
Expand Down
3 changes: 2 additions & 1 deletion src/DaPigGuy/PiggyCustomEnchants/commands/subcommands/EnchantSubCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@
use pocketmine\item\enchantment\EnchantmentInstance;
use pocketmine\item\ItemTypeIds;
use pocketmine\player\Player;
use pocketmine\plugin\Plugin;
use pocketmine\utils\TextFormat;
use Ramsey\Uuid\Uuid;
use Vecnavium\FormsUI\CustomForm;

class EnchantSubCommand extends BaseSubCommand
{
/** @var PiggyCustomEnchants */
protected $plugin;
protected Plugin $plugin;

public function onRun(CommandSender $sender, string $aliasUsed, array $args): void
{
Expand Down
3 changes: 2 additions & 1 deletion src/DaPigGuy/PiggyCustomEnchants/commands/subcommands/InfoSubCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,15 @@
use DaPigGuy\PiggyCustomEnchants\utils\Utils;
use pocketmine\command\CommandSender;
use pocketmine\player\Player;
use pocketmine\plugin\Plugin;
use pocketmine\utils\TextFormat;
use Vecnavium\FormsUI\CustomForm;
use Vecnavium\FormsUI\SimpleForm;

class InfoSubCommand extends BaseSubCommand
{
/** @var PiggyCustomEnchants */
protected $plugin;
protected Plugin $plugin;

public function onRun(CommandSender $sender, string $aliasUsed, array $args): void
{
Expand Down
3 changes: 2 additions & 1 deletion src/DaPigGuy/PiggyCustomEnchants/commands/subcommands/ListSubCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,14 @@
use DaPigGuy\PiggyCustomEnchants\utils\Utils;
use pocketmine\command\CommandSender;
use pocketmine\player\Player;
use pocketmine\plugin\Plugin;
use pocketmine\utils\TextFormat;
use Vecnavium\FormsUI\SimpleForm;

class ListSubCommand extends BaseSubCommand
{
/** @var PiggyCustomEnchants */
protected $plugin;
protected Plugin $plugin;

public function onRun(CommandSender $sender, string $aliasUsed, array $args): void
{
Expand Down
3 changes: 2 additions & 1 deletion src/DaPigGuy/PiggyCustomEnchants/commands/subcommands/NBTSubCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@
use DaPigGuy\PiggyCustomEnchants\PiggyCustomEnchants;
use pocketmine\command\CommandSender;
use pocketmine\player\Player;
use pocketmine\plugin\Plugin;
use pocketmine\utils\TextFormat;

class NBTSubCommand extends BaseSubCommand
{
/** @var PiggyCustomEnchants */
protected $plugin;
protected Plugin $plugin;

public function onRun(CommandSender $sender, string $aliasUsed, array $args): void
{
Expand Down
3 changes: 2 additions & 1 deletion src/DaPigGuy/PiggyCustomEnchants/commands/subcommands/RemoveSubCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@
use DaPigGuy\PiggyCustomEnchants\utils\Utils;
use pocketmine\command\CommandSender;
use pocketmine\player\Player;
use pocketmine\plugin\Plugin;
use pocketmine\utils\TextFormat;
use Vecnavium\FormsUI\CustomForm;

class RemoveSubCommand extends BaseSubCommand
{
/** @var PiggyCustomEnchants */
protected $plugin;
protected Plugin $plugin;

public function onRun(CommandSender $sender, string $aliasUsed, array $args): void
{
Expand Down
Loading