Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
DajosPatryk authored Feb 11, 2024
1 parent 632de05 commit f50b768
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ I kept env variables and secrets on GitHub for testing purposes 📐✏️👷

## What could be improved
- **Response time** - Response time averages at 100ms on my local machine. This is acceptable. I would instead opt for a local database instance to make this faster.
- **Optimal response times** - In order to achieve optimal response times, I would use a minifier for prod, eliminate Prisma altogether and run **Bun** instead of Nodejs.
- **Optimal response times** - In order to achieve optimal response times, I would use a minifier for prod, eliminate Prisma altogether.
- **ULTRA FAST RESPONSE TIMES** - In order to push the limits of JavaScript, I would opt for **Bun** instead of Node.js and Redis instead of MongoDB.
- **Save user ranks to database** - If the database was big, simply running through the entire user list determining ranks would cause performance issues.
- **Error classes** - I kept it basic. Instead of an Error Factory, I'd define custom error classes extending error, those would also not log automatically. Like so: https://www.toptal.com/nodejs/node-js-error-handling
- **More precise handling of internal errors** - I kept it basic, all internal errors are 500, this is not best-practice.
Expand Down

0 comments on commit f50b768

Please sign in to comment.