Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEMELON][WEEK 01](Python) 리트코드 문제 풀이 #300

Merged
merged 7 commits into from
Aug 16, 2024
Merged

[BEMELON][WEEK 01](Python) 리트코드 문제 풀이 #300

merged 7 commits into from
Aug 16, 2024

Conversation

BEMELON
Copy link
Contributor

@BEMELON BEMELON commented Aug 11, 2024 •
edited
Loading

@BEMELON BEMELON self-assigned this Aug 11, 2024
@dev-jonghoonpark
Copy link
Contributor

코드 작성하신 것 잘 보았습니다 👍
앞으로도 잘 부탁드리겠습니다.

개인적인 질문인데
혹시 본문 내용 포멧이 어디에 올라와 있나요?

다들 237을 중복으로 작성하셔서 질문드려봅니다 : )

@BEMELON
Copy link
Contributor Author

BEMELON commented Aug 11, 2024

다들 237을 중복으로 작성하셔서 질문드려봅니다 : )

저는 #299 PR에 있는 내용을 스리슬쩍 가져왔는데, 여기서도 중복이 있네요 😂

@BEMELON BEMELON marked this pull request as ready for review August 11, 2024 15:27
TonyKim9401
TonyKim9401 reviewed Aug 11, 2024
View reviewed changes
contains-duplicate/bemelon.py
Copy link
Contributor

@TonyKim9401 TonyKim9401 Aug 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set 활용이 잘 된것 같습니다!

TonyKim9401
TonyKim9401 reviewed Aug 11, 2024
View reviewed changes
number-of-1-bits/bemelon.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재귀는 생각하지 못했는데, bit 연산을 최적화하여 잘 사용하신것 같습니다!

@BEMELON BEMELON requested a review from TonyKim9401 August 13, 2024 13:07
@BEMELON
Copy link
Contributor Author

BEMELON commented Aug 13, 2024

@TonyKim9401 안녕하세요 혹시 추가로 검토해주실 내용이 없다면 Approve 부탁드릴게요 ㅎㅎ 🙏

TonyKim9401
TonyKim9401 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@TonyKim9401 TonyKim9401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파이썬 코드를 잘 몰라서.. 그래도 시간, 공간 복잡도를 효율 좋게 풀으신것 같습니다. 고생하셨습니다!

@BEMELON BEMELON added the py label Aug 15, 2024
@leokim0922 leokim0922 merged commit 1a6b0f1 into DaleStudy:main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyKim9401 TonyKim9401 TonyKim9401 approved these changes

@leokim0922 leokim0922 leokim0922 approved these changes

Assignees

@BEMELON BEMELON

Labels
py
Projects
No open projects
리트코드 스터디 2기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BEMELON @dev-jonghoonpark @leokim0922 @TonyKim9401