[솔방울] week 1 문제 풀이 #312
Merged
[솔방울] week 1 문제 풀이 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wooseok123
commented
Aug 12, 2024
•
wooseok123
commented
- Contains Duplicate #217
- Number of 1 Bits #232
- Top K Frequent Elements #237
- Kth Smallest Element In a Bst #252
- Palindromic Substrings #267
DaleSeo
reviewed
Aug 13, 2024
| }; | ||
|
|
||
| // TC : O(log n) | SC : O(log n) | ||
| // 근데 사실 split 메서드 자체는 o(n)인데, toString과정을 통해 log(n)의 개수만큼 나와버린 것이면 o(log n)이라고 표기해도 되는걸까? |
There was a problem hiding this comment.
넹, 상관없을 것 같습니다. 내장 함수도 직접 구현하신 코드처럼 시간을 소모하니까요 :)
There was a problem hiding this comment.
아하 애매한 부분이었는데 감사합니다 :)
bky373
reviewed
Aug 15, 2024
Comment on lines
+13
to
+16
| const obj = findAllValuesInTree(root, {}); | ||
| const sortedList = Object.keys(obj) | ||
| .map(Number) | ||
| .sort((a, b) => a - b); |
There was a problem hiding this comment.
안녕하세요, 사소한 리뷰 글 남깁니다~
풀이를 보았을 때 재귀적으로 트리를 순회하여 모든 노드의 값을 객체에 저장한 후,
정렬을 위해 한 번 더 모든 값을 순회하는 것으로 이해하였습니다.
시간 복잡도의 차이는 없겠지만, 순회하는 단계를 1회로 줄여보실 수도 있을 것 같네요!
There was a problem hiding this comment.
아하 BST에서 중위 순회를 하는 경우 이미 오름차순으로 정렬되기 때문에 추가로 순회하는 단계가 생략될 수 있다는 말씀이실까요!?
nhistory
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.