[highball] week2 solutions #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
highballplz
commented
Aug 24, 2024
highballplz
commented
- Valid Anagram
- Counting Bits
- Encode and Decode Strings
- Construct Binary Tree From Preorder And Inorder Traversal
- Decode Ways
DaleSeo
approved these changes
Aug 25, 2024
| @@ -0,0 +1,9 @@ | |||
| const encode = function (arr) { | |||
| const encodedStr = arr.reduce((acc, cur) => acc + "#" + cur); | |||
There was a problem hiding this comment.
문제에서 입력 문자열에 256개의 ASCII 문자가 들어있을 수 있다고 했는데요. #도 ASCII 문자여서 입력 문자열에 #에 포함되어 있는 경우 문제가 될 수 있을 것 같습니다.
tolluset
approved these changes
Aug 25, 2024
| @@ -0,0 +1,9 @@ | |||
| const encode = function (arr) { | |||
| const encodedStr = arr.reduce((acc, cur) => acc + "#" + cur); | |||
There was a problem hiding this comment.
arr.join('#') 도 가능하겠네용! 달레님 코멘트처럼 아스키문자를 피해야 될 것 같아여!
| tCharCount[charAsInt]++; | ||
| }); | ||
|
|
||
| return sCharCount.reduce((acc, cur, i) => acc && cur === tCharCount[i], true); |
There was a problem hiding this comment.
sCharCount.every((count, i) => count === tCharCount[i]); 로 확인할 수도 있겠네용!
검증이라면 every로 모든 값이 일치하는게 메소드가 조금 더 어울리는 것 같아여!
Comment on lines
+5
to
+13
| Array.from(s).forEach((char) => { | ||
| const charAsInt = char.charCodeAt(0) - 97; | ||
| sCharCount[charAsInt]++; | ||
| }); | ||
|
|
||
| Array.from(t).forEach((char) => { | ||
| const charAsInt = char.charCodeAt(0) - 97; | ||
| tCharCount[charAsInt]++; | ||
| }); |
There was a problem hiding this comment.
s와 t의 길이가 같지 않으면 anagram이 아니기 때문에 early retrun 하고 하나의 루프로 체크하는 것도 가능할 것 같아여!
Comment on lines
+9
to
+10
| if (i % 2 === 0) arr[i] = arr[i / 2]; | ||
| else arr[i] = arr[(i - 1) / 2] + 1; |
There was a problem hiding this comment.
arr[i] = i % 2 === 0 ? arr[i / 2] : arr[(i - 1) / 2] + 1;특정 인덱스 값에 대입이어서 값에 대한 삼항으로 처리해도 좋을 것 같네영!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.