[정현준] 3주차 답안 추가 #390
Merged
[정현준] 3주차 답안 추가 #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bky373
reviewed
Aug 28, 2024
Comment on lines
+27
to
+30
| climbStairs(1) shouldBe 1 | ||
| climbStairs(2) shouldBe 2 | ||
| climbStairs(3) shouldBe 3 | ||
| climbStairs(4) shouldBe 5 |
There was a problem hiding this comment.
역시 kotest 가 테스트 코드 가독성이 정말 뛰어난 것 같습니다!
two-sum/jdalma.kt
Outdated
Comment on lines
37
to
39
| if (map.containsKey(diff)) { | ||
| return intArrayOf(map[diff]!!, index) | ||
| } |
There was a problem hiding this comment.
kotlin 의 null safety 장점을 살리기 위해 아래처럼 safe call operator(?.) 를 사용해보면 어떨까요?
map[diff]?.let {
return intArrayOf(it, index)
}NPE 를 선호하신다면 not-null assertion operator(!!) 를 사용하셔도 되나 코틀린의 장점을 생각할 때 보통 지양하는 편이긴 합니다!
There was a problem hiding this comment.
리뷰 감사합니다 ㅎㅎ !!연산은 실무에서는 절대 사용하지 않는 편인데 이 문제에서는 절대 비어있지 않을거라고 생각하고 사용했었네요 ㅠ 말씀하신대로 수정해봤습니다. 버릇을 잘 들여놓아야겠습니다 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.