[GUMUNYEONG] Week4 Solutions #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2024 16:39
HC-kang
reviewed
Sep 5, 2024
There was a problem hiding this comment.
@GUMUNYEONG 안녕하세요 문영님!
4주차 한 주도 고생하셨습니다!
아직 inReview 상태로 두진 않으셨지만, 푸실 문제가 두 개만 올라와 있어서 우선 리뷰 남겼습니다!
리뷰로 넘겨주시면 승인토록 하겠습니다~!
missing-number/GUMUNYEONG.js
Outdated
| // TC | ||
| // nums 정렬을 하기 위해서 순회 (길이 n) | ||
| // 빠진 숫자를 찾기위해서 순회 (최대길이 n) | ||
| // O(2n) 따라서 시간 복잡도는 O(n) |
There was a problem hiding this comment.
정렬을 위한 순회가 최선의 경우에는 Ω(n)이긴 하지만, 평균적으로는 결과가 달라지기 때문에 수정이 필요해 보입니다!
There was a problem hiding this comment.
앗 넵 제가 생각이 짧았던 부분이네요..! 정렬 함수의 시간 복잡도에 대해서 자세히 알아봐야겠습니다. 피드백 감사합니다..!
| str = str.toLowerCase().replace(/[^a-z0-9]/g, ""); | ||
|
|
||
| return str; | ||
| } |
There was a problem hiding this comment.
전처리 기능을 별도 함수로 분리하고자 하는 의도이실까요?
그렇다면 preprocess, sanitize, normalize 등의 작명도 활용하실 수 있을 것 같아요
사실상 한 줄 짜리 함수이다 보니 인라인도 충분히 괜찮지 않을까 해서 의견 드립니다!
There was a problem hiding this comment.
네 가독성이 더 좋다고 판단해서 함수를 따로 빼봤습니다..! 항상 변수명과 함수명을 작성하는데 있어서 어려움을 느끼곤 하는데, 추천해주셔서 감사합니다
HC-kang
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.