Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[재호] WEEK 05 Solutions #438

Merged
merged 6 commits into from
Sep 15, 2024
Merged

[재호] WEEK 05 Solutions #438

merged 6 commits into from
Sep 15, 2024

Conversation

wogha95
Copy link
Contributor

@wogha95 wogha95 commented Sep 8, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@wogha95 wogha95 self-assigned this Sep 8, 2024
@github-actions github-actions bot added the js label Sep 8, 2024
@wogha95 wogha95 marked this pull request as ready for review September 14, 2024 05:51
@wogha95 wogha95 requested a review from a team as a code owner September 14, 2024 05:51
Copy link
Contributor

@bky373 bky373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다~

Comment on lines 2 to 4
* TC: O(N * S)
* SC: O(N)
* N: strs.length, S: strs[i].length
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smax(strs[i].length) 이면 더 명확할 것 같습니다! (평균으로 하는 것도 같구요)
그리고 SC 도 O(N) 에서 S 가 고려되지 않은 것 같습니다 확인 한 번 부탁드립니다~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S 가 max(strs[i].length) 이면 더 명확할 것 같습니다! (평균으로 하는 것도 같구요)

확인 감사합니다. 반영했습니다!

그리고 SC 도 O(N) 에서 S 가 고려되지 않은 것 같습니다 확인 한 번 부탁드립니다~

SC에서 S가 고려되지 않은 이유는 usedCount에서 26개의 고정 배열을 사용하기 때문입니다!

Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@wogha95 wogha95 merged commit b840ada into DaleStudy:main Sep 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants