Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaejeong1] week 5 #454

Merged
merged 4 commits into from
Sep 16, 2024
Merged

[jaejeong1] week 5 #454

merged 4 commits into from
Sep 16, 2024

Conversation

jaejeong1
Copy link
Contributor

@jaejeong1 jaejeong1 commented Sep 13, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@jaejeong1 jaejeong1 self-assigned this Sep 13, 2024
@github-actions github-actions bot added the java label Sep 13, 2024
@jaejeong1 jaejeong1 marked this pull request as ready for review September 14, 2024 08:12
@jaejeong1 jaejeong1 requested a review from a team as a code owner September 14, 2024 08:12
@bky373
Copy link
Contributor

bky373 commented Sep 14, 2024

안녕하세요~

  • best-time-to-buy-and-sell-stock/jaejeong1.java
  • group-anagrams/jaejeong1.java
    ⚠️ 위 파일들의 끝에 누락된 줄 바꿈을 추가 부탁드립니다~

https://github.com/DaleStudy/leetcode-study/actions/runs/10842861783

@jaejeong1
Copy link
Contributor Author

안녕하세요~

  • best-time-to-buy-and-sell-stock/jaejeong1.java
  • group-anagrams/jaejeong1.java
    ⚠️ 위 파일들의 끝에 누락된 줄 바꿈을 추가 부탁드립니다~

https://github.com/DaleStudy/leetcode-study/actions/runs/10842861783

네 추가 했습니다!

Copy link
Contributor

@bky373 bky373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시공간 복잡도도 주석에 추가해주시면 좋을 것 같습니다 <- 아 주석 안에 있는 걸 놓쳤네요
주차가 끝난 시점이라 작업 올려주신 거 승인하였는데 코멘트 확인 부탁드립니다!

private String createAnagramData(String str) {
Map<Character, Integer> map = new HashMap<>();

for (int i=0; i<str.length(); i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 str.length() 만큼 순회가 이루어지니, 시간 복잡도가 O(N) 보다 더 큰 값이어야 할 것 같습니다! (N: strs.length 라는 가정 하에)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bky373
피드백 감사합니다! N이 아닌 N^2 이 되어야 맞겠군요 :) 수정했습니다!

@jaejeong1 jaejeong1 merged commit 193f10b into DaleStudy:main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants