[정현준] 9주차 #521
Merged
[정현준] 9주차 #521
+227
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obzva
reviewed
Oct 11, 2024
| * TC: O(log N), SC: O(1) | ||
| */ | ||
| fun findMin(nums: IntArray): Int { | ||
| var (low, high) = 0 to nums.size - 1 |
There was a problem hiding this comment.
var (low, high) = 0 to nums.size - 1
kotlin에서 pair를 만드는 표현이 참 특이하네요 ㅎㅎ
obzva
reviewed
Oct 11, 2024
Comment on lines
+9
to
+20
| while (low + 1 < high) { | ||
| val mid = (low + high) / 2 | ||
| if (nums[mid - 1] > nums[mid]) { | ||
| return nums[mid] | ||
| } | ||
| if (nums[mid] < nums[high]) { | ||
| high = mid | ||
| } | ||
| else { | ||
| low = mid | ||
| } | ||
| } |
There was a problem hiding this comment.
이진탐색 로직이 깔끔하고 좋습니다 ㅎㅎ
저도 현준님 풀이에 영감을 얻어서 제 풀이를 좀 더 다듬을 수 있었습니다 :)
https://github.com/DaleStudy/leetcode-study/pull/520/files#diff-d02da092874d1658e6fb39bb2d7221b29a6fe6804b26e2c460bdd0e2243dd373
There was a problem hiding this comment.
전에 obzva님이 전달해주신 이진 검색 정리 게시글을 본게 도움 많이 되었습니다! 감사합니다 ㅎㅎ
obzva
approved these changes
Oct 11, 2024
| * TC: O(n * m), SC: O(n * m) | ||
| */ | ||
| fun pacificAtlantic(heights: Array<IntArray>): List<List<Int>> { | ||
| val (row, col) = heights.size to heights.first().size |
There was a problem hiding this comment.
코틀린에 문법 관련 단순 질문입니다 :)
이렇게 튜플 형태로 변수를 초기화하면 '한 줄에 작성하기'외에 혹시 다른 장점이 있나요?
There was a problem hiding this comment.
제가 알기로는 가독성 외에는 딱히 다른 장점은 없는걸로 알고있습니다 ㅎㅎ
@jdalma 님, 다음부터 Week 설정 빼먹지 않도록 좀 부탁드리겠습니다. 🙇♂️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.