Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flynn] Week13 #576

Merged
merged 7 commits into from
Nov 9, 2024
Merged

[Flynn] Week13 #576

merged 7 commits into from
Nov 9, 2024

Conversation

obzva
Copy link
Contributor

@obzva obzva commented Nov 4, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@obzva obzva marked this pull request as ready for review November 4, 2024 17:28
@obzva obzva requested a review from a team as a code owner November 4, 2024 17:28
Comment on lines 17 to 19
if len(intervals) <= 1 {
return true
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

길이가 1 이하면 for 문을 순회하지 않으니 조건이 없어도 될 것 같습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇네요 ㅎㅎ 감사합니다~!

@obzva obzva requested a review from DaleSeo November 6, 2024 07:49
@obzva
Copy link
Contributor Author

obzva commented Nov 6, 2024

@DaleSeo 첫 pr이라 리뷰어 지정할 분이 없어서 부득이하게 달레님으로 리뷰어 지정하였습니다 :)

@DaleSeo DaleSeo requested a review from mangodm-web November 7, 2024 21:07
@DaleSeo
Copy link
Contributor

DaleSeo commented Nov 7, 2024

@DaleSeo 첫 pr이라 리뷰어 지정할 분이 없어서 부득이하게 달레님으로 리뷰어 지정하였습니다 :)

@obzva 관행에 따라서 지난 주의 마지막 답안 제출자인 @mangodm-web 님을 리뷰어로 추가해드렸어용~ (참고 문서)

Copy link
Contributor

@mangodm-web mangodm-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go는 사용해본 적이 없는데,
코드를 깔끔하게 작성해주시고 주석도 넣어주신 덕분에 리뷰하기가 수월했던 것 같아요.
이번 한 주도 고생하셨습니다! 😃

@obzva
Copy link
Contributor Author

obzva commented Nov 9, 2024

아이고 리뷰하느라 수고하셨겠네요.. 감사합니다! 한 주 고생하셨습니다 :)

@obzva obzva merged commit 1cdfe5c into DaleStudy:main Nov 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants