[강희찬] WEEK 15 Solution #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
approved these changes
Nov 22, 2024
Comment on lines
+12
to
+13
| const len1 = expandBothSides(s, i, i); // odd | ||
| const len2 = expandBothSides(s, i, i + 1); // even |
There was a problem hiding this comment.
별거 아닙니다만, 평소 알고리즘 푸는 습관이 그대로 코드에 드러난다고 생각하기 때문에 변수 명을 odd, even과 관련된 걸로 했으면 주석이 없어도 괜찮지 않았을까 싶습니다 :)
Comment on lines
+24
to
+25
| if (!p && !q) return true; | ||
| if (!p || !q) return false; |
There was a problem hiding this comment.
이거 혹시 한줄로
if(!p || !q) reutrn !p && !q;
로 바꿀 수 있지 않을까요?
한줄 한줄의 의미를 살리고 가독성 면에서는 명확하게 전달하는 측면에서는 현재 풀이가 좋다고 생각합니다!
There was a problem hiding this comment.
early return인데 24, 25줄이 서로 겹치는 부분이 있어서 조금 애매한 것 같습니다.
if !p && !q
else if (p && q) && (p.val == q.val)
else
이렇게 나누면 겹치는 조건 없이 else문에서 (!p && q) || (p && !q) || (p.val != q.val) 조건을 처리하기 좋을 것 같습니다
|
15주 동안 수고 많으셨습니다. 그 동안 적극적으로 리뷰 남겨주셔서 참 감사했습니다. 풀이도 좋으시고 덕분에 많이 배울 수 있었습니다. 감사합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.