Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phenomenal_star_75309] Week 2 #736

Merged
merged 6 commits into from
Dec 22, 2024
Merged

[phenomenal_star_75309] Week 2 #736

merged 6 commits into from
Dec 22, 2024

Conversation

suhacs
Copy link
Contributor

@suhacs suhacs commented Dec 18, 2024 •
edited
Loading

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@suhacs suhacs requested a review from a team as a code owner December 18, 2024 02:41
@github-actions github-actions bot added the js label Dec 18, 2024
@suhacs suhacs requested a review from thispath98 December 18, 2024 02:45
TonyKim9401
TonyKim9401 reviewed Dec 21, 2024
View reviewed changes
valid-anagram/suhacs.js
Comment on lines +2 to +6
let temp = t;
for (char of s) {
temp = temp.replace(char, "");
}
return temp === "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t를 그대로 사용 안하시고 temp로 사용하신 이유가 있을지 궁금합니다 :)

TonyKim9401
TonyKim9401 approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@TonyKim9401 TonyKim9401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2주차 문제풀이 고생 많으셨습니다!
1주차 문제도 같이 올려주셨네요. 주 1문제라도 괜찮으니 꾸준히 하시는 모습 기대하고 있겠습니다!
3주차도 파이팅입니다!

@SamTheKorean SamTheKorean merged commit fb00558 into DaleStudy:main Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyKim9401 TonyKim9401 TonyKim9401 approved these changes

@thispath98 thispath98 Awaiting requested review from thispath98

Assignees

@suhacs suhacs

Labels
js
Projects
리트코드 스터디 3기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suhacs @TonyKim9401 @SamTheKorean