[ysle0] Week2 #742
Merged
[ysle0] Week2 #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ysle0 님 안녕하세요! |
taewanseoul
approved these changes
Dec 21, 2024
valid-anagram/ysle0.go
Outdated
Comment on lines
11
to
13
| if !ok { | ||
| return false | ||
| } |
There was a problem hiding this comment.
밑에서 포문으로 한번 걸러주는 로직 덕분에 이 조건문은 없어도 되는 것 같습니다~
There was a problem hiding this comment.
@taewanseoul
극단적인 경우엔 해당 조건문이 상당한 양의 연산을 줄일 수 있습니다
// 예
s = "a...a" // (길이 5 * 10^4)
t = "b...b" // (길이 5 * 10^4)
There was a problem hiding this comment.
@ysle0
isAnagram 함수의 body 가장 앞단에 아래와 같은 로직도 있으면 좋을 것 같네요 :)
func isAnagram(s string, t string) bool {
if len(s) != len(t) {
return false
}
...There was a problem hiding this comment.
아 그렇겠네요 경계검사 조건 피드백 감사합니다!
| ret = append(ret, ret[i-1]+ret[i-2]) | ||
| } | ||
|
|
||
| ret = ret[len(ret)-2:] |
There was a problem hiding this comment.
javascript의 slice 메소드가 이렇게 다르게 생겼군요!
There was a problem hiding this comment.
네.. 저도 처음에 이렇게 slicing 하는 것 보고 되게 신기했었어요 ㅎㅎ
|
아직 solving 상태로 되어 있으셨군요...! 제가 모르고 리뷰 했습니다. 죄송합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.