[Lyla] Week 02 solutions #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgonD3V
approved these changes
Dec 21, 2024
Comment on lines
+17
to
+31
| if nums[left] + nums[right] == target: | ||
| result.append([num, nums[left], nums[right]]) | ||
|
|
||
| # skip duplicated numbers ( ex. nums = [-3 0 0 0 3 3] ) | ||
| while left < right and nums[left] == nums[left + 1]: | ||
| left += 1 | ||
| while left < right and nums[right] == nums[right -1]: | ||
| right -= 1 | ||
|
|
||
| left += 1 | ||
| right -= 1 | ||
| elif nums[left] + nums[right] < target: | ||
| left += 1 | ||
| else: | ||
| right -= 1 |
There was a problem hiding this comment.
가독성을 위해서 left index와 right index가 움직이는 자명한 케이스를 위로 올려서, 가장 중요한 로직이 else문에 위치하게 하면 좋을 것 같습니다
| inorder_map = {value: idx for idx, value in enumerate(inorder)} | ||
| self.preorder_idx = 0 | ||
|
|
||
| def helper(left: int, right: int) -> Optional[TreeNode]: |
There was a problem hiding this comment.
helper 보다는 로직이나 역할이 드러나는 함수명이 좋을 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.