Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jinah92] Week 2 #752

Merged
merged 5 commits into from
Dec 21, 2024
Merged

[jinah92] Week 2 #752

merged 5 commits into from
Dec 21, 2024

Conversation

jinah92
Copy link
Contributor

@jinah92 jinah92 commented Dec 20, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@jinah92 jinah92 requested a review from mintheon December 20, 2024 08:03
Copy link
Contributor

@EgonD3V EgonD3V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2주차도 수고 많으셨습니다 시간복잡도와 공간복잡도 계산을 연습해보시면 도움이 되실 것 같습니다

char_set_1, char_set_2 = {}, {}

for ch in s:
char_set_1[ch] = 0 if ch not in char_set_1 else char_set_1[ch] + 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조건 표현식도 좋지만, 이렇게 긴 경우에는 .get 메서드의 기본값을 사용해보시면 가독성에 도움이 되실 것 같습니다.

@@ -0,0 +1,20 @@
# 공간복잡도 : O(1), 시간복잡도 : O(N^2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three_sums의 크기 때문에 공간복잡도가 O(1) 보다 클 것 같습니다.

@jinah92 jinah92 merged commit 32d3a22 into DaleStudy:main Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants