Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HerrineKim] Week 2 #754

Merged
merged 3 commits into from
Dec 21, 2024
Merged

[HerrineKim] Week 2 #754

merged 3 commits into from
Dec 21, 2024

Conversation

HerrineKim
Copy link
Contributor

@HerrineKim HerrineKim commented Dec 20, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@HerrineKim HerrineKim requested a review from HiGeuni December 20, 2024 17:19
@HerrineKim HerrineKim requested a review from a team as a code owner December 20, 2024 17:19
@github-actions github-actions bot added the js label Dec 20, 2024
Copy link
Contributor

@EgonD3V EgonD3V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2주차도 수고 많으셨습니다 화이팅

Comment on lines +12 to +13
if (index === s.length) return 1;
if (s[index] === '0') return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적으로 이 early return 조건문들은 재귀 호출과 독립적으로 동작할 수 있는 조건들이기 때문에, helper 클로져 밖에 있는게 좋을 것 같습니다

@HerrineKim HerrineKim merged commit 6720ea5 into DaleStudy:main Dec 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants